![]() > It might make sense to bind the this object to those calls in some cases, to Removing the listener would be nice indeed. (In reply to Philipp Kewisch from comment #6) Strangely even after setting that preference I still didn't get any. > If you enable strict warnings you will get a notification about the unknown (In reply to Stefan Sitter from comment #5) Splinter Review This adds third parameter and also removes listeners when unloading a window. In addition I think there should be an onUnload handler to remove the listeners from folder tree and thread tree. I think once onLoad / addListeners is called you should remove the "load" listener to not leak it. The default value might change like currently happening in Bug 937461 and therefore causing Lightning Bug 937470. You should pass |false| as the 3rd parameter to addEventListener() like done everywhere else in calendar code to not rely upon default values. ![]() ![]() > Source File: chrome://calendar/content/calendar-extract.js Line: 207 > Warning: ReferenceError: reference to undefined property tState If you enable strict warnings you will get a notification about the unknown |this| like In my understanding calendar-extract.js contains just a bunch of methods that are only defined inside |calendarExtract| namespace to not pollute the global namespace. Commenting out this line allows initialization to continue and the status bar is shown again. I assume the wrong line |calendarExtract.addListeners() | causes an failure during an loading but it seems the error is nowhere reported.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |